Skip to content

fix(vscode): improve question option contrast#11922

Open
LEN5010 wants to merge 8 commits into
Kilo-Org:mainfrom
LEN5010:fix/question-option-contrast
Open

fix(vscode): improve question option contrast#11922
LEN5010 wants to merge 8 commits into
Kilo-Org:mainfrom
LEN5010:fix/question-option-contrast

Conversation

@LEN5010

@LEN5010 LEN5010 commented Jul 3, 2026

Copy link
Copy Markdown

Issue

Fixes #11794

Context

QuestionDock radio and checkbox outlines can blend into the background in low-contrast light themes such as Eva Light, making unselected options difficult to locate.

Implementation

Use VS Code's --vscode-button-background token for the default QuestionDock option-box border instead of the generic --border-base token.

This only changes the normal unselected border. Existing selected-state fill/border and focus-visible styles are unchanged.

Screenshots / Video

image

How to Test

Manual/local verification

  • Built the VS Code Storybook successfully.
  • Verified the QuestionDock story renders option controls with the updated theme token.
  • Ran extension typecheck and lint successfully.
  • Ran question-dock-contract.test.ts: 5 passed.

Reviewer test steps

  1. Check out this PR.
  2. Run bun install.
  3. Run bun run extension from the repository root.
  4. In the Extension Development Host, install and select the Eva Light color theme.
  5. Open Kilo and trigger a question containing multiple-choice options.
  6. Confirm each unselected radio/checkbox outline is clearly visible.
  7. Select an option and confirm its existing selected state still renders normally.
  8. Keyboard-focus an option and confirm its existing focus outline still appears.

Blocked checks and substitute verification

  • The full VS Code unit suite completed 3024/3025 tests. The unrelated WorktreeManager.resolveStartPoint test expected remote but received local-tracking.
  • Substitute verification: targeted QuestionDock tests, typecheck, lint, Storybook build, and pre-push cross-package typecheck passed.

Checklist

  • Issue linked above, or exception explained
  • Tests/verification described
  • Screenshots/video included for visual changes, or marked N/A
  • Changeset considered for user-facing changes
  • I personally reviewed the diff and can explain the changes, including any AI-assisted work.

@LEN5010 LEN5010 marked this pull request as ready for review July 3, 2026 15:35
@LEN5010 LEN5010 closed this Jul 3, 2026
@kilo-code-bot

kilo-code-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • packages/kilo-vscode/webview-ui/src/styles/question-dock.css
  • .changeset/fix-question-option-contrast.md

Reviewed by claude-sonnet-5-20260630 · Input: 20 · Output: 3.5K · Cached: 417.7K

Review guidance: REVIEW.md from base branch main

@LEN5010 LEN5010 reopened this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option selector not visible

1 participant