get-changed-files: fix core.warn crash on multi-PR push events#229
Merged
Conversation
The github-script core API method is core.warning; core.warn does not exist. The call sits on the path taken only when a pushed commit is associated with more than one open PR (stacked PRs), so instead of warning and proceeding with the first PR, the action crashed with 'core.warn is not a function'.
🦋 Changeset detectedLatest commit: 5637b13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
khan-actions-bot
requested review from
a team,
kevinb-khan and
somewhatabstract
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/get-changed-filescrashes withcore.warn is not a functionon push events when the pushed commit is associated with more than one open PR. The github-scriptcoreAPI method iscore.warning;core.warndoes not exist, and the test mock stubbedwarnso the suite never caught it. The path fires exactly for stacked PRs (a commit that is the head of one PR and part of another), which is how #227 surfaced it: its "Testing with 'push' events" check dies on this line instead of warning and proceeding with the first associated PR.One-line fix plus the matching test-mock rename.
cc @jeresig
Testing
npx vitest run actions/get-changed-files: 40 tests green, including the multi-PR warn path.pnpm build(tsc) compiles clean.