review: thumbs-sweep reaction seeding (opt-in) and self-reaction filtering#223
Merged
Conversation
🦋 Changeset detectedLatest commit: 014d94b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
khan-actions-bot
requested review from
a team,
kevinb-khan and
somewhatabstract
and removed request for
a team
Open
2 tasks
jeresig
approved these changes
Jul 9, 2026
jwbron
added a commit
that referenced
this pull request
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two additions to
workflows/review/lib/thumbs-sweep.ts, ahead of scheduling the sweep on webapp and frontend:seedReactions: truein the sweep config): each sweep seeds one 👍 and one 👎, from the bot itself, on any reviewer comment that lacks them, so readers see the feedback buttons instead of having to open the reaction picker. Idempotent: only missing seeds are added (the bot's existing reactions are checked per comment).botLogin. Without this, the seeded 👎 would make every comment count as downvoted and the sweep would follow-up-spam every thread. A reaction with no attributed login is conservatively treated as a real user's.The port gains an optional
addReactions(grain, commentId, contents)method; enabling seeding without implementing it fails loudly at sweep start. 9 new tests cover seeding, idempotency, the off-by-default path, self-filtering, real-user reactions alongside seeds, and config validation. Existing behavior is unchanged whenseedReactionsis absent.