Fixes #39292 - Add cache HIT/MISS logging for Candlepin proxy caches#11727
Fixes #39292 - Add cache HIT/MISS logging for Candlepin proxy caches#11727pablomh wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The HTTP requests (iirc) are all logged when the application is in debug mode so it's already easy to infer if there was a cache miss (http request logged) or a hit (no http request logged). |
|
The HIT/MISS logging uses the dedicated :logging:
:loggers:
:registration:
:level: debugSo operators get cache observability by setting one logger to debug, not by running the whole application in debug mode. |
|
Pausing my review here until #11692 reaches a resolution |
|
Emit debug-level log lines via the :registration named logger (Foreman #39290) for each cached Candlepin endpoint: - compliance cache: "compliance cache=HIT/MISS uuid=<uuid>" - candlepin status cache: "rhsm_status cache=HIT/MISS" At the default info level, no additional log lines appear. Enable with :registration logger at debug level. Depends on: - Foreman #39290 (:registration named logger) - Katello #39195 (compliance cache) - Katello #39204 (candlepin status cache) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
c97d170 to
7695247
Compare
|
I'll leave it in draft mode until theforeman/foreman#10946 is merged. |
Summary
Emit debug-level log lines via the
:registrationnamed logger for each cached Candlepin endpoint, enabling operators to verify cache effectiveness in production.Log output (at debug level)
At the default info level, no additional log lines appear.
Dependencies
This is a draft PR that requires these PRs to merge first:
:registrationnamed logger (Redmine #39290)Will rebase onto master once dependencies are merged.
How to test
:logging: :loggers: :registration: :level: debugcache=HITandcache=MISSlines