Support IPv6 addresses for HTTP proxies in yum repo discovery#11518
Draft
ekohl wants to merge 1 commit into
Draft
Support IPv6 addresses for HTTP proxies in yum repo discovery#11518ekohl wants to merge 1 commit into
ekohl wants to merge 1 commit into
Conversation
Fixes: d609612 ("Fixes #38545 - Support IPv6 addresses in HTTP proxy URLs (Katello#11432)")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incomplete, but so I can share this patch.
What are the changes introduced in this pull request?
Fixes: d609612 ("Fixes #38545 - Support IPv6 addresses in HTTP proxy URLs (#11432)")
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Summary by Sourcery
Enable correct handling of IPv6 addresses in HTTP proxy URLs by switching proxy_host to use URI#hostname and introducing proxy_hostname to maintain legacy behavior.
Bug Fixes:
Enhancements: