Skip to content

redesign notify system - #85

Merged
KHeresy merged 1 commit into
mainfrom
new-notify
Sep 27, 2026
Merged

KHeresy merged 1 commit into
mainfrom
new-notify

Conversation

@KHeresy

@KHeresy KHeresy commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner
  • feat: Add persisted notification modes for original web notifications or Messenger-only app notifications
  • feat: Detect new messages through conversation changes, with unread badges and page titles as fallback signals
  • feat: Add optional message previews and a persistent Windows taskbar unread indicator with manual clearing
  • fix: Deduplicate signals for the same message while allowing later new messages to notify again
  • build: Bump Electron to 44.4.5

@KHeresy
KHeresy merged commit cc515a6 into main Sep 27, 2026
11 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 101b7138c9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread main.js
Comment on lines +796 to +800
mainWindow.webContents.on('did-start-navigation', (details) => {
if (details.isMainFrame && !details.isSameDocument) {
mainWindow.resetMessengerNotification();
observedUnreadCount = null;
monitoringReadyAt = Date.now() + 5000;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset unread baselines on navigation

did-start-navigation supplies positional arguments (event, url, isInPlace, isMainFrame, ...), so details is the event object and has neither isMainFrame nor isSameDocument; this reset branch therefore never runs. After a full navigation or redirect, the initial unread badge on the newly loaded Messenger page is compared with the previous page's count instead of being baselined during the intended five-second grace period, which can produce a background notification for already-existing unread messages.

Useful? React with 👍 / 👎.

@KHeresy
KHeresy deleted the new-notify branch September 27, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant