Repository navigation
Fix typos in "Create New Samplers and Distributions" docs - #2084
Merged
Merged
Conversation
Reported on Discourse: a user copy-pasted `DiscreteUnivarateDistribution` from the documentation and hit an `UndefVarError`. https://discourse.julialang.org/t/creating-a-new-distibution-with-distributions-jl/138436 - `DiscreteUnivarateDistribution` -> `DiscreteUnivariateDistribution` - `DiscreteMultivarateDistribution` -> `DiscreteMultivariateDistribution` - Matrix-variate sampler section said "multivariate sampler" and `Sampleable{Multivariate,S}`; it should be `Sampleable{Matrixvariate,S}` - "as wells as" -> "as well as" Assisted-by: AI
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2084 +/- ##
=======================================
Coverage 86.74% 86.74%
=======================================
Files 149 149
Lines 8883 8883
=======================================
Hits 7706 7706
Misses 1177 1177 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported on Discourse: a user copy-pasted
DiscreteUnivarateDistributionfrom the documentation and hit anUndefVarError. https://discourse.julialang.org/t/creating-a-new-distibution-with-distributions-jl/138436DiscreteUnivarateDistribution->DiscreteUnivariateDistributionDiscreteMultivarateDistribution->DiscreteMultivariateDistributionSampleable{Multivariate,S}; it should beSampleable{Matrixvariate,S}Assisted-by: AI