Repository navigation
Conversation
conv specializes per element type, dimensionality and algorithm; a test suite or first real use pays for compiling each combination (the overlap-save edge kernels alone are ~24 method instances). A small PrecompileTools workload covers (Float64, Float32, ComplexF64) x 1/2/3-d x (:direct, :fft_simple, :fft_overlapsave) plus filt.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 97.98% 98.00% +0.01%
==========================================
Files 19 20 +1
Lines 3332 3354 +22
==========================================
+ Hits 3265 3287 +22
Misses 67 67 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pankgeorg
marked this pull request as draft
August 31, 2026 10:16
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convspecializes per element type, dimensionality and algorithm, so a test suite or first real use pays for compiling each combination at runtime (the overlap-save edge kernels alone are ~24 method instances). This adds a small PrecompileTools workload covering (Float64, Float32, ComplexF64) × 1/2/3-d × (:direct, :fft_simple, :fft_overlapsave) plusfilt.Measured on aarch64, Julia 1.12: a cold run of
test/dsp.jlunderPkg.testflags drops from 222 s to 209 s (warm runs unchanged); the runtime-compiledunsafe_conv_kern_os_edge!instances go from 24 to 0. Package precompile grows by a few seconds, paid once.Tested: full test suite passes with the workload in place.