Skip to content

Do not automatically include the Content-MD5 HTTP header#765

Draft
omus wants to merge 3 commits into
masterfrom
cv/drop-content-md5
Draft

Do not automatically include the Content-MD5 HTTP header#765
omus wants to merge 3 commits into
masterfrom
cv/drop-content-md5

Conversation

@omus

@omus omus commented Mar 20, 2026

Copy link
Copy Markdown
Member

Fixes #695.

@mattBrzezinski mattBrzezinski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess to include this functionality users will need to specify the header themselves? Does the removal of this have other implications?

@omus

omus commented Mar 20, 2026

Copy link
Copy Markdown
Member Author

If someone is using sig_aws4! directly they could include the header by adding it into the request. Other typical AWS.jl use cases will no exclude the header which as shown in #695 isn't required by any of the API calls and additionally we always include the x-amz-content-sha256 header.

@omus
omus added this pull request to the merge queue Mar 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 20, 2026
@omus
omus added this pull request to the merge queue Mar 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 23, 2026
@omus

omus commented Mar 23, 2026

Copy link
Copy Markdown
Member Author

Integration tests caught an issue:

<Error><Code>InvalidRequest</Code><Message>Missing required header for this request: Content-MD5 OR x-amz-checksum-*</Message><RequestId>03V7TDDC5SETNQES</RequestId><HostId>jnbR5hz0lH+e7x6pAjodJZiBdy1ek0J0dFOAYqgR+GQrH/5XJXq5UY2i/N0NHF0TRSdza1Gg2zo=</HostId></Error>

I think what happened is I did my analysis on newer service definitions and older ones require Content-MD5 or x-amz-checksum-* like the error states.

@omus

omus commented Mar 23, 2026

Copy link
Copy Markdown
Member Author

I think I'll push this into the v2 release as this should be more straight forward to apply. Possibly I still could run into needing to add x-amz-checksum-* which may not be marked as required as there are multiple algorithms to choose from: https://docs.aws.amazon.com/AmazonS3/latest/userguide/checking-object-integrity.html

@omus
omus marked this pull request as draft March 23, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic inclusion of Content-MD5 header breaks S3.upload_part_copy

2 participants