Repository navigation
fix(patcher): prevent ReVanced 21 and 22 process startup crashes - #723
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix ReVanced 21 and 22 process-mode patching failing before patches are applied.
Standalone app_process package contexts can have a null applicationContext. The shared storage helper assumed an Application was available, causing a NullPointerException during ReVanced 22 runtime asset preparation and ReVanced 21 runtime plugin loading.
The fix is in the Manager's shared storage handling and covers both runtimes without requiring a separate v21 plugin change.
Changes
Testing
Artifact
https://github.com/Jman-Github/Universal-ReVanced-Manager/actions/runs/35389662467/artifacts/10565332808
Note
PR build data and regular release data are kept separate to prevent conflicts when switching between release builds and PR artifacts. Because of this, when you install a PR artifact, your app data will appear to be reset. It’s only a clean slate for that specific PR build. Your previous data is still preserved, and once you reinstall the release build you were using before, that data will be restored.
Validation
git diff --checkpassed..\gradlew.bat assembleReleasepassed.