Repository navigation
Serve the Finance Database icon from the MCP server - #245
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding https://financedatabase.jeroenbouma.com/mcp to claude.ai shows a default icon. Today
/and/favicon.icoreturn a plain-text 404, so favicon lookups find nothing. This change gives the server the Finance Database icon.site_model.pyserves the icon:/favicon.ico: an ICO with 16, 32 and 48 px images./favicon-32.png,/apple-touch-icon.png(180 px) and/icon.png(the full 512 px icon).mcpb/finance_database_icon.pngand cached for a day./is a short HTML page for browsers: a title, the icon links and a link to the MCP documentation page. MCP traffic stays on/mcp. The page doesn't redirect, so lookups don't end up at the website's own icon.icons(MCPImplementation.icons, pointing to/icon.png) andwebsite_url, both set inconfig.yaml.The server serves no OAuth metadata, so there is no
logo_urito set. Tested with a Starlette test client on every route and on the initialization options; the full test suite passes. The icons are in the wheel. The production server needs a redeploy frommainafter merge.