Repository navigation
Count ranked coins as listed so new coins are not removed the week after - #227
Merged
Merged
Conversation
Coins only in CoinGecko's market ranking (e.g. Bittensor subnet tokens such as SN64) were added one week and removed the next, because removal only checked the full coin list and stripped trailing digits (SN64 -> SN). A coin now counts as listed when either list has its ticker, with or without a Yahoo-style number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a back-and-forth in the weekly crypto update.
What happened
The removal rule had two flaws:
Fix
A coin counts as listed when either CoinGecko list has its ticker, as it is or without a trailing number. Against live CoinGecko data, the next run would add back those 8 coins plus one new one (POD) and remove none. A test covers a ranked-only coin with a ticker ending in digits.
Checks: the markets, listings and layout tests, and black.