Repository navigation
Native AOT: the hosted daemon, subscriptions, side effects, raw SQL and a second store (#430) - #432
Merged
Merged
Conversation
…nd a second store (#430) The five paths native-aot.md listed as never measured in a native image. smoke/aot-consumer/UnmeasuredPaths.cs runs each natively, on a store and file of its own. - The hosted daemon (AddAsyncDaemon), a subscription, a message and an event raised from a projection's RaiseSideEffects, and AdvancedSql / QueueSqlCommand all ran natively with no change. - AddFisherStore<T>() cannot: its marker is a DispatchProxy, which emits a type at runtime and throws PlatformNotSupportedException in a native image. New AddFisherStore<T, TImplementation>() takes a store class the application declares (an empty DocumentStore subclass implementing the marker). Every consumer of the marker already unwrapped through SecondaryStoreProxy.Unwrap, so nothing downstream changed. The one-argument overload now refuses by name in a native image, naming the class to declare; the smoke asserts that refusal natively. - Compiled samples in native-aot.md and multiple-stores.md. Closes #430 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jeremydmiller
force-pushed
the
fisher-aot-unmeasured-paths
branch
from
October 4, 2026 23:01
05e6658 to
8d6da92
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #430. Stacked on #431 (Weasel 9.41), so it targets that branch. Retarget to
mainbefore #431 merges, or GitHub will close this PR. CI doesn't run on it until then.Measured natively (macOS arm64, ILC 10.0.1)
smoke/aot-consumer/UnmeasuredPaths.csruns each path in the native image, each on a store and file of its own:AddAsyncDaemon()), a subscription, a message and an event raised fromRaiseSideEffects, andAdvancedSql/QueueSqlCommand: all worked with no change.AddFisherStore<T>(): failed. Its marker is aDispatchProxy, which emits a type at runtime (AssemblyBuilder.DefineDynamicAssembly→PlatformNotSupportedException). That's a .NET limitation, not something in Fisher.The fix: a declared store class
New public API,
AddFisherStore<T, TImplementation>():DocumentStorealready implements everything the marker inherits, so the class body is empty.SecondaryStoreProxy.Unwrap, which returns a non-proxy store as-is, and a declared class is anIEventStoreand the document tooling interfaces.native-aot.mdandmultiple-stores.md.Verification
multi_store_registrationgains a JIT test for the declared store: isolation,StoreName, and the monitoring registrations resolving to the store itself.check_scoreboard.pyagrees for both TFMs; leak check clean.🤖 Generated with Claude Code