Repository navigation
[SDK-758] Lock the pre-init switch failure result - #1094
Open
joaodordio wants to merge 1 commit into
Open
joaodordio wants to merge 1 commit into
joaodordio wants to merge 1 commit into
Conversation
A switchProject before initialization reports switchedWithWarnings when start fails and switchedCleanly when it succeeds, the same two results Android now reports.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/SDK-674-switch-project #1094 +/- ##
==================================================================
+ Coverage 75.02% 75.11% +0.09%
==================================================================
Files 118 118
Lines 10618 10618
==================================================================
+ Hits 7966 7976 +10
+ Misses 2652 2642 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
A switchProject before init reports switchedWithWarnings when start fails, and switchedCleanly when it succeeds.
🎟️ Jira Ticket: SDK-758
📖 Description
switchProjectbefore initialization already forwardedstart()'s result. This locks that in tests and in the changelog.A failed
start()(the first in-app sync is the usual cause) reports.switchedWithWarnings. A successful one reports.switchedCleanly. Android now reports the same two results. On Android the failure signal is a timeout or an exception from background initialization, not a failed in-app sync. Reasoning is on the Jira ticket.Targets
feature/SDK-674-switch-project. Independent of SDK-757. Android: Iterable/iterable-android-sdk#1101🧪 How to test?
SwitchProjectGateTests:testSwitchProjectBeforeInitializeReportsCleanlyWhenStartSucceedstestSwitchProjectBeforeInitializeReportsWarningsWhenStartFails🧾 Changelog
Updated the unreleased
switchProjectentry. A pre-init switch reports.switchedCleanlywhenstart()succeeds and.switchedWithWarningswhen it fails.📹 Loom recording if applicable
N/A
🐞 Github Issues solved
None
📚 Docs PR if applicable
No docs PR.
switchProjectis not in iterable-docs yet. That write-up is SDK-676, and this result contract is noted there.