Repository navigation
[SDK-757] Replay queued switch calls against the destination they were requested for - #1093
Open
joaodordio wants to merge 1 commit into
Open
joaodordio wants to merge 1 commit into
joaodordio wants to merge 1 commit into
Conversation
…e requested for A call made after a later switchProject was requested was replayed into the switch already in flight. Each queued call now stays with that destination, in order.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/SDK-674-switch-project #1093 +/- ##
==================================================================
+ Coverage 75.02% 75.10% +0.07%
==================================================================
Files 118 118
Lines 10618 10631 +13
==================================================================
+ Hits 7966 7984 +18
+ Misses 2652 2647 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Replay queued switchProject calls against the destination they were requested for, not the switch that lands first.
🎟️ Jira Ticket: SDK-757
📖 Description
A call made after a later
switchProjectwas requested was replayed into the switch already in flight.ProjectSwitchGatenow keeps each queued call with the switch leg that was the latest ask when the call was made. A drain only replays that leg. A call made from a switch callback still runs immediately against the project that just landed. Two asks for the same API key, with another destination between them, stay separate, so order is preserved within each destination.Targets
feature/SDK-674-switch-project. Independent of SDK-758. Android: Iterable/iterable-android-sdk#1100🧪 How to test?
SwitchProjectGateTests:testACallMadeAfterALaterDestinationWasRequestedWaitsForThatDestinationtestFifoIsPreservedWithinEachDestinationAcrossAChain🧾 Changelog
Updated the unreleased
switchProjectentry. A call made after a later destination has been requested is replayed against that destination.📹 Loom recording if applicable
N/A
🐞 Github Issues solved
None
📚 Docs PR if applicable
No docs PR.
switchProjectis not in iterable-docs yet. That write-up is SDK-676, and the queue contract is noted there.