Repository navigation
Conversation
ImranR98
commented
Oct 24, 2026
ImranR98
commented
Owner
- Restore the open-in-browser action for app source pages (Open in external browser - please add it back #3448)
- Request update ownership on Shizuku installs (Follow-up on: Use update ownership API on initial app install #3445)
The app detail page showed the source URL but offered no explicit way to open it externally, and the URL in the app info dialog was plain text. Restore the external-browser affordance with an Open in browser button next to the URL and make the dialog URL tappable again. Verified on the Android 17 emulator: tapping the new button opened the system browser chooser for the ReadYou source page. Added a widget test for the dialog action.
The stock installer already asks Android 14+ for update ownership, but the Shizuku plugin built its PackageInstaller session without it. Add an optional requestUpdateOwnership argument to the forked plugin (pinned at ImranR98/shizuku_apk_installer@447d88a0) and pass it from Obtainium only for fresh installs, where Android accepts update ownership. Verified on the Android 17 emulator with Shizuku: a fresh ReadYou install through Obtainium produced updateOwnerPackageName=com.android.shell, while adb-installed apps on the same emulator had no ownership field. Dart unit tests cover the option forwarding.
# Conflicts: # assets/translations/ja.json # lib/components/app_detail_widgets.dart # test/app_info_dialog_test.dart
Bump file_picker to 13.2.0 (file_picker_darwin 2.3.4) and the flutter_charset_detector_android transitive to 4.0.2. Keep fluttertoast pinned at 10.0.0: 10.0.1+ applies KGP unconditionally, which breaks the AGP 9 built-in Kotlin setup. connectivity_plus, material_color_utilities, and several transitive packages have newer versions that are not mutually resolvable. Verified with flutter analyze, dart format, the full test suite (459 passed), and a release build of the normal flavor. Phone E2E passed 15 suites through add_without_check; the install-as-downloaded suite aborts in the Flutter test runner on this emulator, and reproduced the same failure with the package changes stashed. The install/update suite is skipped because this emulator cannot complete a silent install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.