Skip to content

Address BDN use of - - #63

Merged
viceroypenguin merged 1 commit into
mainfrom
fix
Jul 27, 2026
Merged

Address BDN use of -#63
viceroypenguin merged 1 commit into
mainfrom
fix

Conversation

@viceroypenguin

@viceroypenguin viceroypenguin commented Jul 27, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Improved assembly identifier normalization by removing hyphens when no custom identifier is configured.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3d66a37f-2c2a-4f20-b2c5-9b48761022ce

📥 Commits

Reviewing files that changed from the base of the PR and between 30fe9cc and bd00eb1.

📒 Files selected for processing (1)
  • src/Immediate.Injections.Generators/ImmediateInjectionsGenerator.cs

📝 Walkthrough

Walkthrough

Changes

Assembly Identifier Generation

Layer / File(s) Summary
Fallback identifier normalization
src/Immediate.Injections.Generators/ImmediateInjectionsGenerator.cs
GetAssemblyIdentifier now removes hyphens from fallback assembly identifiers alongside dots and whitespace.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the change: it addresses hyphen handling in the assembly identifier fallback path.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 30314458471

Coverage increased (+0.003%) to 96.16%

Details

  • Coverage increased (+0.003%) from the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1250
Covered Lines: 1202
Line Coverage: 96.16%
Coverage Strength: 3.85 hits per line

💛 - Coveralls

@viceroypenguin
viceroypenguin merged commit ae65ca6 into main Jul 27, 2026
3 checks passed
@viceroypenguin
viceroypenguin deleted the fix branch July 27, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assembly identifier does not strip -, unlike Immediate.Handlers/Apis, producing invalid method names

2 participants