Document Immediate.Jobs skipped job state - #14
Merged
Conversation
📝 WalkthroughWalkthroughThe documentation defines ChangesJobs lifecycle and monitoring
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/content/docs/Immediate.Jobs/configuring-storage-providers.md`:
- Around line 125-126: Update the storage-provider migration documentation to
explicitly require adding the non-null SkippedCount column, backfilling all
existing batch rows with 0, and applying a default of 0 for future inserts
before provider startup.
In `@src/content/docs/Immediate.Jobs/delivery-guarantees.md`:
- Around line 53-63: Clarify the retention precedence for skipped members in
successful batches in the retention documentation near the
BatchSucceededRetention and SucceededRetention descriptions. Explicitly state
which setting controls skipped members when the enclosing batch succeeds, while
preserving the existing batch-as-a-unit deletion behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 36dac156-336c-4201-8b58-ba4f875b0b4b
📒 Files selected for processing (10)
src/content/docs/Immediate.Jobs/api-reference.mdsrc/content/docs/Immediate.Jobs/batches-and-continuations.mdsrc/content/docs/Immediate.Jobs/configuring-storage-providers.mdsrc/content/docs/Immediate.Jobs/creating-jobs.mdsrc/content/docs/Immediate.Jobs/dashboard-and-monitoring.mdsrc/content/docs/Immediate.Jobs/delivery-guarantees.mdsrc/content/docs/Immediate.Jobs/diagnostics.mdsrc/content/docs/Immediate.Jobs/how-it-works.mdsrc/content/docs/Immediate.Jobs/recurring-jobs.mdsrc/content/docs/Immediate.Jobs/testing-jobs.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracks the user-facing changes in ImmediatePlatform/Immediate.Jobs#77, ImmediatePlatform/Immediate.Jobs#80, and ImmediatePlatform/Immediate.Jobs#81.
Validation
Summary by CodeRabbit
AwaitingParameters,Active, andSkipped.