CsrfCounterMeasure: Only reject unsafe requests upon validation#396
Merged
nilmerg merged 1 commit intoJul 14, 2026
Merged
Conversation
nilmerg
force-pushed
the
properly-ignore-safe-methods-in-csrf-counter-measures
branch
from
July 13, 2026 12:46
dc04b57 to
b1c3fde
Compare
Al2Klimov
previously approved these changes
Jul 13, 2026
Al2Klimov
reviewed
Jul 13, 2026
TheSyscall
previously approved these changes
Jul 13, 2026
Al2Klimov
approved these changes
Jul 14, 2026
Calling `$form->isValid()` explicitly right after construction throws an error as the csrf element is validated and has no value. Similarly, assembling a form with such an element should only fail if it is validated. This does not fix an issue, it will only streamline the behavior. It also ensures expectations of poeple familiar with form request handling (like me) are met.
nilmerg
force-pushed
the
properly-ignore-safe-methods-in-csrf-counter-measures
branch
from
July 14, 2026 10:49
d1daf2a to
535b120
Compare
nilmerg
deleted the
properly-ignore-safe-methods-in-csrf-counter-measures
branch
July 14, 2026 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
$form->isValid()explicitly right after construction throws an error as the csrf element is validated and has no value. Similarly, assembling a form with such an element should only fail if it is validated.This does not fix an issue, it will only streamline the behavior. It also ensures expectations of poeple familiar with form request handling (like me) are met.