Support configuration of event rules for generic sources#471
Merged
Conversation
BastianLedererIcinga
force-pushed
the
configure-rules-without-integration
branch
from
May 7, 2026 11:59
457f0fa to
889baa6
Compare
BastianLedererIcinga
force-pushed
the
rule-filter-handling
branch
2 times, most recently
from
May 19, 2026 07:46
015bfb8 to
d8a98b8
Compare
BastianLedererIcinga
force-pushed
the
rule-filter-handling
branch
2 times, most recently
from
May 22, 2026 14:02
1fb39c8 to
a4e2aa2
Compare
BastianLedererIcinga
force-pushed
the
configure-rules-without-integration
branch
3 times, most recently
from
May 26, 2026 09:33
52667d2 to
d57ae09
Compare
sukhwinder33445
previously requested changes
May 28, 2026
nilmerg
requested changes
May 28, 2026
Contributor
Author
|
The failing tests are unrelated to this PR, they are caused by the API tests being incompatible with recent changes to the schema. |
nilmerg
requested changes
Jun 2, 2026
nilmerg
requested changes
Jun 2, 2026
nilmerg
requested changes
Jun 2, 2026
nilmerg
requested changes
Jun 2, 2026
nilmerg
requested changes
Jun 2, 2026
BastianLedererIcinga
force-pushed
the
configure-rules-without-integration
branch
from
June 3, 2026 08:34
88d3200 to
0f2929c
Compare
nilmerg
requested changes
Jun 3, 2026
nilmerg
approved these changes
Jun 3, 2026
Allow the user to fisrt select `generic` or `integrated`, only śhow the source identifier field for `integrated` and adjust the descriptions.
Create a simple `SearchEditor` without suggestions, enrichment and validation when editing the filter of a genric rule.
BastianLedererIcinga
force-pushed
the
configure-rules-without-integration
branch
from
June 3, 2026 09:54
920bdf6 to
742d4f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For event rules of generic sources a simple
SearchEditorwithout enrichment, validation and suggestions is created.resolve #450
require Icinga/ipl-web#384
require Icinga/ipl-web#358