IONOS(theming): fix #content-vue offset for standalone and nested apps - #369
Merged
Merged
Conversation
a186e83 reset #content-vue to margin 0 by default, which moved standalone app containers (e.g. Deck) under the header. Apps that mount #content-vue inside the core #content wrapper (Talk, Contacts, Notes, Tasks, ...) inherited the wrapper's side margin, leaving a gap on the left and overflowing on the right. The framed variant for Mail, Tasks, Tables and Settings left a gap on the left as well. Place #content-vue edge-to-edge below the header, drop the offset when it is nested in the core #content wrapper, and make that wrapper edge-to-edge like the dashboard. Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Visual verification remains incomplete for several affected apps.
Review effort: Lite
Findings: None
What changed in this PR
Fixes IONOS content positioning for standalone and nested apps.
Changes:
- Restores standalone header offset.
- Removes duplicate nested offsets.
- Makes relevant wrappers edge-to-edge.
| File | Description |
|---|---|
apps/theming/css/ionos/_layout.css |
Adjusts app and core content layout rules. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to a186e83, which reset
#content-vuetomargin: 0by default and caused two layout regressions:#content) slid under the header.#content-vuesits inside core#content) inherited the wrapper's 8px side margin: gap on the left, overflow on the right. The "framed" variant for Mail, Tasks, Tables and Settings also left a gap on the left.Changes in
apps/theming/css/ionos/_layout.css:#content-vueis edge-to-edge below the header by default; the per-app overrides are gone.#content,#content-vuedrops its own header offset (the wrapper already has it).#contentis edge-to-edge when it holds#content-vue, sharing one rule with the dashboard (uses:has()).#content.app-tasks { margin: 0 }, now covered by the rules above.Verified in the browser at 1900px (header 64px): Files, Mail, Tables, Tasks, Deck, Talk, Notes, Dashboard and Settings → Apps all render at
x=0, y=64, full width, no horizontal overflow. Contacts, Calendar, Collectives, Forms and Activity share the nested structure but were not re-measured after the final change.TODO
Checklist
3. to review, feature component)stable32)