IONOS(assistant): fix generated file download format (NSW-1017) - #362
Draft
printminion-co wants to merge 1 commit into
Draft
printminion-co wants to merge 1 commit into
printminion-co wants to merge 1 commit into
Conversation
…type) Fixes generated-file downloads in the assistant being served as application/octet-stream without an extension. Backports upstream nextcloud/assistant#592 and nextcloud#660 (finfo-based mimetype detection). IONOS-Productivity/nc-assistant#4 Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
apps-external/assistant16ee5ff6 → ffec4000 to fix NSW-1017: when you download a file produced by the assistant's "Generate file", it is served asapplication/octet-streamand has no usable extension.Fork PR: IONOS-Productivity/nc-assistant#4 (cherry-picks of upstream nextcloud/assistant#592 and nextcloud#660, which replace
mime_content_type()on wrapped storage streams withfinfo->buffer()).Sibling PR for v32: #361
Test
Assistant → Generate file → .md → PDF/DOCX/ODT → Download. The response has the correct
Content-Typeand the file saves with an extension. This also works for past tasks.Jira: NSW-1017