Skip to content

URB-3660: Use reception date for incoming notice event dates - #604

Open
daggelpop wants to merge 1 commit into
2.9.xfrom
URB-3660_reception_date
Open

URB-3660: Use reception date for incoming notice event dates#604
daggelpop wants to merge 1 commit into
2.9.xfrom
URB-3660_reception_date

Conversation

@daggelpop

@daggelpop daggelpop commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Note:
The receptionDate data received so far has never been missing.
No clear fix if that changes, so no point in checking for None at the moment.

Summary by CodeRabbit

  • Bug Fixes
    • Incoming notice events now use the notice’s reception date as the event date, ensuring more accurate event timelines.

@daggelpop
daggelpop requested a review from mpeeters July 28, 2026 14:37
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e082d23-7b18-4fb5-b1f4-c4761d4dbe4c

📥 Commits

Reviewing files that changed from the base of the PR and between cfe46fa and 840358a.

📒 Files selected for processing (2)
  • news/URB-3660.bugfix
  • src/Products/urban/browser/cron/notice.py

📝 Walkthrough

Walkthrough

Incoming notice events now derive their event date from notification.reception_date instead of send_date or status_date. A release note records the behavior change and includes the [daggelpop] marker.

Changes

Incoming notice date handling

Layer / File(s) Summary
Reception date event assignment
src/Products/urban/browser/cron/notice.py, news/URB-3660.bugfix
fill_incoming_event sets the event date from notification.reception_date; the release note documents this change and adds the [daggelpop] marker.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • IMIO/Products.urban#602: Updates parsing of incoming notice data, including reception_date, in the related notice pipeline.

Suggested reviewers: mpeeters, wboudabous

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: incoming notice event dates now use the reception date.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch URB-3660_reception_date

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant