URB-3651: Add index and widget to filter by last received NOTICe notification - #603
Open
daggelpop wants to merge 3 commits into
Open
URB-3651: Add index and widget to filter by last received NOTICe notification#603daggelpop wants to merge 3 commits into
daggelpop wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (36)
🚧 Files skipped from review as they are similar to previous changes (36)
📝 WalkthroughWalkthroughAdds a ChangesLast received notice notification
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant LicenceEvents
participant last_received_notice_notification
participant UrbanCatalog
participant DashboardCriterion
LicenceEvents->>last_received_notice_notification: find newest incoming notice event
last_received_notice_notification->>UrbanCatalog: index notification timestamp
DashboardCriterion->>UrbanCatalog: apply selected date range
UrbanCatalog->>DashboardCriterion: return filtered records
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/Products/urban/dashboard/config/codt_integratedlicences.xml`:
- Around line 187-196: Move each c96 criterion to the dashboard object matching
its file: in src/Products/urban/dashboard/config/codt_integratedlicences.xml use
codt_integratedlicences (anchor lines 187-196); in
src/Products/urban/dashboard/config/codt_notaryletters.xml use
codt_notaryletters (lines 176-185); in
src/Products/urban/dashboard/config/inspections.xml use inspections (lines
175-184); in src/Products/urban/dashboard/config/integratedlicences.xml use
integratedlicences (lines 176-185); and in
src/Products/urban/dashboard/config/miscdemands.xml use miscdemands (lines
177-186).
In `@src/Products/urban/dashboard/config/codt_uniquelicences.xml`:
- Around line 187-196: Move each c96 criterion under the correct enclosing
GenericSetup object: in
src/Products/urban/dashboard/config/codt_uniquelicences.xml#L187-L196 use
codt_uniquelicences; in
src/Products/urban/dashboard/config/codt_urbancertificatetwos.xml#L187-L196 use
the urban-certificate-twos object; in
src/Products/urban/dashboard/config/declarations.xml#L94-L103 use declarations
instead of schedule; in
src/Products/urban/dashboard/config/divisions.xml#L176-L185 use divisions; and
in src/Products/urban/dashboard/config/envclassborderings.xml#L187-L196,
src/Products/urban/dashboard/config/envclassones.xml#L187-L196, and
src/Products/urban/dashboard/config/envclasstwos.xml#L187-L196 use their
corresponding environmental-class object.
In `@src/Products/urban/dashboard/config/roaddecrees.xml`:
- Around line 164-173: Correct the dashboard root object names before installing
criterion c96: in src/Products/urban/dashboard/config/roaddecrees.xml lines
164-173, rename explosivespossessions to roaddecrees; in
src/Products/urban/dashboard/config/tickets.xml lines 175-184, rename
explosivespossessions to tickets; in
src/Products/urban/dashboard/config/uniquelicences.xml lines 176-185, rename
codt_commerciallicences to uniquelicences; in
src/Products/urban/dashboard/config/urbancertificateones.xml lines 165-174,
rename codt_urbancertificateones to urbancertificateones; and in
src/Products/urban/dashboard/config/urbancertificatetwos.xml lines 176-185,
rename codt_commerciallicences to urbancertificatetwos.
In `@src/Products/urban/migration/update_290.py`:
- Around line 706-738: Update add_last_received_notice_notification to also
include the existing urban/import-notice folder in urban_dashboard_folders when
present, alongside the root and URBAN_TYPES folders. Retrieve it safely and
append it only when available, so the existing c96 criteria creation loop
applies to that dashboard without changing other folder handling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 2cd664e9-f9ab-46dd-956e-cfed54305929
📒 Files selected for processing (42)
news/URB-3651.featuresrc/Products/urban/dashboard/config/all.xmlsrc/Products/urban/dashboard/config/article127s.xmlsrc/Products/urban/dashboard/config/buildlicences.xmlsrc/Products/urban/dashboard/config/codt_article127s.xmlsrc/Products/urban/dashboard/config/codt_buildlicences.xmlsrc/Products/urban/dashboard/config/codt_commerciallicences.xmlsrc/Products/urban/dashboard/config/codt_integratedlicences.xmlsrc/Products/urban/dashboard/config/codt_notaryletters.xmlsrc/Products/urban/dashboard/config/codt_parceloutlicences.xmlsrc/Products/urban/dashboard/config/codt_uniqueborderinglicences.xmlsrc/Products/urban/dashboard/config/codt_uniquelicences.xmlsrc/Products/urban/dashboard/config/codt_urbancertificateones.xmlsrc/Products/urban/dashboard/config/codt_urbancertificatetwos.xmlsrc/Products/urban/dashboard/config/declarations.xmlsrc/Products/urban/dashboard/config/divisions.xmlsrc/Products/urban/dashboard/config/envclassborderings.xmlsrc/Products/urban/dashboard/config/envclassones.xmlsrc/Products/urban/dashboard/config/envclassthrees.xmlsrc/Products/urban/dashboard/config/envclasstwos.xmlsrc/Products/urban/dashboard/config/explosivespossessions.xmlsrc/Products/urban/dashboard/config/housings.xmlsrc/Products/urban/dashboard/config/import_notice.xmlsrc/Products/urban/dashboard/config/inspections.xmlsrc/Products/urban/dashboard/config/integratedlicences.xmlsrc/Products/urban/dashboard/config/miscdemands.xmlsrc/Products/urban/dashboard/config/notaryletters.xmlsrc/Products/urban/dashboard/config/parceloutlicences.xmlsrc/Products/urban/dashboard/config/patrimonycertificates.xmlsrc/Products/urban/dashboard/config/preliminarynotices.xmlsrc/Products/urban/dashboard/config/projectmeetings.xmlsrc/Products/urban/dashboard/config/roaddecrees.xmlsrc/Products/urban/dashboard/config/tickets.xmlsrc/Products/urban/dashboard/config/uniquelicences.xmlsrc/Products/urban/dashboard/config/urbancertificateones.xmlsrc/Products/urban/dashboard/config/urbancertificatetwos.xmlsrc/Products/urban/index.zcmlsrc/Products/urban/indexes.pysrc/Products/urban/migration/update_290.pysrc/Products/urban/migration/upgrades_290.zcmlsrc/Products/urban/profiles/default/metadata.xmlsrc/Products/urban/profiles/urban_types/catalog.xml
daggelpop
marked this pull request as draft
July 29, 2026 07:43
daggelpop
marked this pull request as ready for review
July 29, 2026 09:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit