URB-3640: implement pm ep courrier commune notification by WBoudabous · Pull Request #570 · IMIO/Products.urban

WBoudabous · 2026-06-01T07:10:00Z

This PR implements notification handling for PM_EP_COURRIER_COMMUNE

Summary by CodeRabbit

New Features
- Added support for the PM_EP_COURRIER_COMMUNE public inquiry notification in modified-plans workflows.
- Enabled this notification for date, ticket, and opinion transfer processes.
Bug Fixes
- Routed PM_EP_COURRIER_COMMUNE notifications to the amended-plans workflow.
Documentation
- Added French translation support for the notification.
- Added a release/news entry documenting its handling.

coderabbitai · 2026-06-01T07:10:13Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

This pull request adds PM_EP_COURRIER_COMMUNE support to notice routing, GÉSPER transfer views, feature text, and translation catalogs.

Changes

Notice Type Feature Enablement

Layer / File(s)	Summary
Cron notice handling updates `src/Products/urban/browser/cron/notice.py`	`PM_EP_COURRIER_COMMUNE` routes to `GesperAmendedPlansSPWHandler`. Related logging and formatting changes preserve existing processing behavior.
GÉSPER transfer view acceptance `src/Products/urban/browser/urbaneventviews.py`	Three GÉSPER EP transfer views accept `PM_EP_COURRIER_COMMUNE`.
Feature text and translations `news/URB-3640.feature`, `src/Products/urban/locales/fr/LC_MESSAGES/urban.po`, `src/Products/urban/locales/urban-manual.pot`, `src/Products/urban/locales/urban.pot`	The feature entry and gettext catalogs define the new notification key. The French catalog provides its translation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

IMIO/Products.urban#567: Adds related notification routing, transfer-view acceptance, and translation changes.
IMIO/Products.urban#568: Adds another notification type across the same processing and localization paths.
IMIO/Products.urban#569: Extends related commune notification handling and translations.

Suggested reviewers: mpeeters

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 26.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the implementation of the PM_EP_COURRIER_COMMUNE notification, which is the main change in the pull request.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch URB-3640_implement_PM_EP_COURRIER_COMMUNE_notification

_{Comment @coderabbitai help to get the list of available commands.}

mpeeters

Can you fix the conflict ?

mpeeters

Please fix the comments

mpeeters · 2026-06-22T10:25:10Z

            "DEMANDE_AVIS_FACULTATIF_PLAN_MODIFIE_1_ERE_INSTANCE",
            "DEMANDE_ENQUETE_PUBLIQUE_PLAN_MODIFIE_1_ERE_INSTANCE",
-            "DEMANDE_ANNONCE_PROJET_PLAN_MODIFIE_1_ERE_INSTANCE",
+            "DEMANDE_ANNONCE PROJET_PLAN_MODIFIE_1_ERE_INSTANCE",


There is a withspace in the code, please remove it

There is still a whitespace in the code.

mpeeters · 2026-06-23T13:49:38Z

            "DEMANDE_AVIS_FACULTATIF_PLAN_MODIFIE_1_ERE_INSTANCE",
            "DEMANDE_ENQUETE_PUBLIQUE_PLAN_MODIFIE_1_ERE_INSTANCE",
-            "DEMANDE_ANNONCE_PROJET_PLAN_MODIFIE_1_ERE_INSTANCE",
+            "DEMANDE_ANNONCE PROJET_PLAN_MODIFIE_1_ERE_INSTANCE",


There is still a whitespace in the code.

mpeeters · 2026-06-25T13:12:33Z

                    failed_notice_id, exc, retry=True
                )
                logger.exception(
-                    u"%s",


Must remain unicode

mpeeters · 2026-06-25T13:12:48Z

                savepoint.rollback()
                custom_exc = ErrorProcessingNotificationException(notice_id, exc)
                logger.exception(
-                    u"%s",


Must remain unicode

mpeeters · 2026-06-25T13:13:03Z

        except Exception as exc:
            custom_exc = FailedGettingRecentNotificationsException(exc)
            logger.exception(
-                u"%s",


Must remain unicode

mpeeters · 2026-06-25T13:13:46Z

-            u"<p>${msg} for informations: ${data}</p>",
+            "<p>${msg} for informations: ${data}</p>",
            mapping={
                "msg": msg,
-                "data": u", ".join(
-                    [u"{0}: {1}".format(k, v) for k, v in serialized_data.items()]


Must remain unicode

mpeeters · 2026-06-25T13:15:01Z

                self.event.setDecision(urban_decision_term)
            else:
                self.event.setDescription(
-                    u"Décision: {}".format(self.notification.decision_code)


Must remain unicode

mpeeters · 2026-06-25T13:15:12Z

                self.event.setDecision(urban_decision_term)
            else:
-                self.event.setDescription(
-                    u"Décision: {}".format(decision_code)


Must remain unicode

WBoudabous requested a review from mpeeters June 4, 2026 12:32

mpeeters approved these changes Jun 22, 2026

View reviewed changes

WBoudabous force-pushed the URB-3640_implement_PM_EP_COURRIER_COMMUNE_notification branch from 7391aa7 to 591781a Compare June 22, 2026 10:12

mpeeters changed the title ~~Urb 3640 implement pm ep courrier commune notification~~ URB-364:0 implement pm ep courrier commune notification Jun 22, 2026

mpeeters requested changes Jun 22, 2026

View reviewed changes

mpeeters changed the title ~~URB-364:0 implement pm ep courrier commune notification~~ URB-3640: implement pm ep courrier commune notification Jun 22, 2026

WBoudabous requested a review from mpeeters June 22, 2026 13:09

mpeeters requested changes Jun 23, 2026

View reviewed changes

WBoudabous force-pushed the URB-3640_implement_PM_EP_COURRIER_COMMUNE_notification branch from 6f3b6aa to 0a9e239 Compare June 24, 2026 07:51

WBoudabous requested a review from mpeeters June 24, 2026 07:52

mpeeters requested changes Jun 25, 2026

View reviewed changes

WBoudabous added 6 commits August 3, 2026 13:08

Handle PM_EP_COURRIER_COMMUNE_notification

2eb6c17

add translate

7839679

add changlog

da158fa

Apply review comments

3c70583

Apply review comments

ba0c108

fix unicode

d40b8c6

WBoudabous force-pushed the URB-3640_implement_PM_EP_COURRIER_COMMUNE_notification branch from 4277dd9 to d40b8c6 Compare August 3, 2026 11:13

WBoudabous requested a review from mpeeters August 3, 2026 11:13

Uh oh!

Conversation

WBoudabous commented Jun 1, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

mpeeters left a comment

Choose a reason for hiding this comment

Uh oh!

mpeeters left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

WBoudabous commented Jun 1, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 1, 2026 •

edited

Loading