Repository navigation
Conversation
BTooltip's default triggers are hover + focus. A native <button> keeps focus after a mouse click, so its tooltip stayed visible until something else stole focus. preventDefault on mousedown stops a mouse click from focusing the button at all - the click itself still fires normally, only the resulting focus is denied. Keyboard activation (Tab, then Enter/Space) is unaffected since it focuses via focus(), not mousedown, so the tooltip-on-focus behavior keyboard/screen-reader users rely on still works exactly as before.
Collaborator
Author
|
Rolling back — dropping this approach for now, keeping the current focus/tooltip behavior as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BTooltip's default triggers are hover + focus. A native
<button>keeps focus after a mouse click, so its tooltip stays visible until something else steals focus.Adds
@mousedown.preventonButtonIcon's rootb-button: it stops a mouse click from focusing the button at all (click still fires normally), while keyboard activation (Tab, then Enter/Space) is unaffected since it focuses viafocus(), notmousedown— the tooltip-on-focus behavior keyboard/screen-reader users rely on keeps working.