Skip to content

Feature | Primary Navigation Menu Accessibility - #717

Open
ThatcherK wants to merge 2 commits into
developfrom
feature/primary-nav-accessibility
Open

Feature | Primary Navigation Menu Accessibility#717
ThatcherK wants to merge 2 commits into
developfrom
feature/primary-nav-accessibility

Conversation

@ThatcherK

Copy link
Copy Markdown
Contributor

Ticket #711

  • This will fix the Suspicious link text alert, but will not fix redundant link, because the link on the read more button in the highlight feature is the same as the on the main navigation bar for each page. This can therefore only be fixed by getting rid of the button( Which may not be feasible)
  • The added heading text I have added to differentiate the read more buttons cannot currently be seen, because a translation for it does not exist at the moment

@ThatcherK
ThatcherK requested a review from akmiller01 May 12, 2023 10:12
@ThatcherK
ThatcherK force-pushed the feature/primary-nav-accessibility branch from 3f8a051 to 4412af8 Compare May 12, 2023 10:17
@akmiller01

Copy link
Copy Markdown
Contributor

Hmm, from a design-standpoint I don't think it makes much sense to have buttons with text like Tools and Resources Read More. So this one might best be solved with the ability to edit that button text in the CMS. Or park this part of the accessibility for now until there's time to work on the CMS, as that would add additional complications with having the mega-nav retranslated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants