Skip to content

a11y(attachments): restore keyboard focus with :focus-visible #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vidminas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

a11y(attachments): restore keyboard focus with :focus-visible #3337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion modules/blox/assets/css/views/attachments.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,23 @@
.hb-attachment-link {
@apply inline-block font-semibold uppercase outline-none mr-4 mb-1.5 transition-all text-sm tracking-wide focus:outline-none;
@apply inline-block font-semibold uppercase mr-4 mb-1.5 transition-all text-sm tracking-wide;

color: var(--color-primary-600);
}

/* Keyboard focus indicator. Previously the outline was hard-removed
(outline-none + focus:outline-none) with no :focus-visible replacement, so
these buttons had no visible keyboard focus (WCAG 2.4.7). :focus-visible
restores a ring for keyboard users without showing one on mouse click. */
.hb-attachment-link:focus-visible {
outline: 2px solid var(--color-primary-600);
outline-offset: 2px;
border-radius: 2px;
}

.dark .hb-attachment-link:focus-visible {
outline-color: var(--color-primary-400);
}

.hb-attachment-link:hover {
color: var(--color-primary-700);
text-decoration: underline;
Expand Down