[codex] make request timeout configurable - #552
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe API request timeout is configurable through ChangesAPI request timeout
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The request timeout remains 15 seconds by default, supports configured values, and can be disabled with 0; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/env.md`:
- Line 19: Update the HEMMELIG_REQUEST_TIMEOUT entry in the environment
documentation to state that zero or negative values disable the application
timeout, matching api/app.ts behavior; do not imply that only zero disables it.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d92eb646-3d07-427f-ac75-b5184ee06754
📒 Files selected for processing (3)
api/app.tsapi/config.tsdocs/env.md
Summary
HEMMELIG_REQUEST_TIMEOUTin seconds, keeping the current 15-second default0disables the app-level timeoutFixes #551
Validation
HEMMELIG_REQUEST_TIMEOUT=0: app timeout disabledHEMMELIG_REQUEST_TIMEOUT=60: custom timeout appliednpm run build: passed (8,246 modules transformed)git diff --check: passedSummary by CodeRabbit
New Features
HEMMELIG_REQUEST_TIMEOUT.Documentation