fix(input): segment Thai composing text by word boundaries - #2531
Open
Scott-Nx wants to merge 1 commit into
Open
fix(input): segment Thai composing text by word boundaries#2531Scott-Nx wants to merge 1 commit into
Scott-Nx wants to merge 1 commit into
Conversation
Contributor
|
Drive-by review: Presumably there are other scripts we may add in future that also behave this way. Would it make sense to replace the Thai-specific hard-coded aspects with a method in app/src/main/java/helium314/keyboard/latin/utils/ScriptUtils.kt, perhaps something like |
This comment was marked as outdated.
This comment was marked as outdated.
Scott-Nx
marked this pull request as draft
July 17, 2026 09:42
Scott-Nx
marked this pull request as ready for review
July 17, 2026 12:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With suggestions enabled, Thai text will remain one long composing word because Thai normally has no spaces between words.
This causes suggestions to use the entire phrase and require pressing Space twice: once to commit the composing text and once to insert the space.
This change segments Thai composing text at word boundaries. Completed words are committed individually, while only the latest word remains composing.
Reproduction
ภาษาไทยดี.Before this change, the whole phrase remain composing and the first Space only commits it.
After this change, suggestions follow the current Thai word and one Space press inserts the expected space.
Changes
BreakIterator.Testing
Added tests for:
The affected
InputLogicTestandScriptUtilsTestsuites pass.Source
Follows the investigation in https://codeberg.org/Helium314/aosp-dictionaries/pulls/83.