Improve CI texture image support - #944
Open
LucretiaArc wants to merge 3 commits into
Open
Conversation
LucretiaArc
requested review from
Reonu,
arthurtilly and
gheskett
as code owners
August 8, 2026 14:20
gheskett
approved these changes
Aug 8, 2026
gheskett
left a comment
Collaborator
There was a problem hiding this comment.
Wait n64graphics already supported CI this entire time? What on earth was that script for lol
Collaborator
|
i always used binpng for ci textures. okay but literally who has ever used a non-rgba16 ci texture is that a thing |
Collaborator
|
ia16 apparently 🤷 |
Collaborator
|
who has ever used ia16 ever |
Collaborator
|
People that like transparent gradients I guess |
Collaborator
|
ia8 has 4 bit alpha |
Collaborator
|
Yeah but 4 bits of not alpha isn't very smooth |
Collaborator
|
still, i cant think of any situation where you wouldnt either wanna multitex with rgba or could just use i8 |
gheskett
requested changes
Aug 10, 2026
gheskett
reviewed
Aug 10, 2026
gheskett
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current CI texture image implementation has two issues:
Fast-64/fast64#719 adds an option to export CI texture images with texel format information in the file name, and n64graphics already supported CI textures, so this PR solves both problems at once.
Also: