fix: return a friendly 422 instead of a 500 when a form fails validation - #425
Merged
Merged
Conversation
post_form didn't catch pydantic's ValidationError, so a malformed email or a radio answer from a page opened before the form's options changed crashed with a 500 and no message. Catch it and name the fields that failed, using the labels the member sees. Log only field names and error types, since the input is PII. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJTrZnhWMDKQ51nmshVqsJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes GlitchTip ONBOARD-3N (7 events).
post_formcalledmodel(**inp)without catching pydantic'sValidationError, so any submission that failed form validation returned a 500 and the member saw nothing useful. Two causes seen in the events:Now it's a 422 that names the fields that failed, using the labels the member sees, which
form.jsshows in its error banner:app/util/forms.py: newform_field_labels()maps field keys to their visible label. Quiz radios use their scenario heading.app/routes/api.py: catchesValidationError, logs a warning with field names and error types only (the input is PII), and raises the 422.Testing
pytest: 65 passed, 1 skipped.ruffandpyreflyclean.🤖 Generated with Claude Code
https://claude.ai/code/session_01VJTrZnhWMDKQ51nmshVqsJ