Repository navigation
fix: relax oauthlib scope check so extra Discord scopes don't 500 - #418
Merged
Merged
Conversation
Discord's token response has started granting "applications.commands" alongside the requested "identify email guilds.join" scopes (likely tied to the bot now registering slash commands). oauthlib treats any scope mismatch, including a harmless superset, as fatal and raises it as an exception during fetch_token(), which was crashing /api/oauth/ with a 500 (seen in Sentry). The app never reads the OAuth scope itself, so relax the check via OAUTHLIB_RELAX_TOKEN_SCOPE instead of requiring an exact match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ByV6ZkqrAFHoKdWhGZQAiK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/oauth/was 500ing (seen in Sentry) because Discord's token response now grantsapplications.commandsin addition to the requestedidentify email guilds.joinscopes — likely tied to the bot registering slash commands.oauthlibtreats any scope mismatch, even a harmless superset, as fatal by default and raises it as an exception insidefetch_token().OAUTHLIB_RELAX_TOKEN_SCOPE=1instead of requiring an exact match.Test plan
/discord/new/and confirm the/api/oauth/callback completes without a 500 even when Discord grants extra scopes.🤖 Generated with Claude Code