Repository navigation
test: a hashed guard keeps protected names out of every file; the bench guards ledgers by content - #75
Merged
Conversation
…ch guards ledgers by content The repository may not name the company the old app identifier carried, or a related product, project or person. The checks that kept them out spelt the words in pieces, which is a trace of its own. crates/lumen-core/tests/protected_names.rs now holds only their SHA-256 and scans every tracked file, text or binary, for any run of letters that hashes to one, in any case and inside longer words. There is no allow-list. The pieces-based check in the bench's pins test is gone. The bench's real-ledger guard named the previous data folder through the app identifier, which no longer tells the two apart. It now guards every folder directly under the platform's data root that holds a lumen.db, whatever it is called, as well as the current folder and ~/.lumen_db_path. METHOD.md says so. The v1.5.1 meter script's pin is updated to the script as it is now committed at that tag. Tests: protected_names (4 planted cases and the repository: no hit); the sandbox test plants a previous install under a neutral name. lumen-bench 278 and the workspace without the app crate (1,469 tests) pass; clippy -D warnings is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the pieces-based name checks with a guard that holds only SHA-256 hashes, and scans every tracked file, text or binary, with no allow-list. The bench's real-ledger guard now finds ledgers by content (any
lumen.dbdirectly under the data root), so it no longer depends on the old identifier. It also re-pins the v1.5.1 meter script at its tag. lumen-bench (278 tests) and the workspace without the app crate (1,469 tests) pass. No release.