Skip to content

[fix] Vacation recommendation with nemo 25.04 - #345

Open
gabisponciano wants to merge 4 commits into
mainfrom
fix/vacation-recommendation-nemo-25.04
Open

gabisponciano wants to merge 4 commits into
mainfrom
fix/vacation-recommendation-nemo-25.04

Conversation

@gabisponciano

@gabisponciano gabisponciano commented Nov 26, 2025

Copy link
Copy Markdown
Contributor
  • New packages version on requirements
  • opset set to 17 on onnx_export.py file

disclaimer: minor incompatibility between packeges. Doesn't affect the BP result or deploy
tensorflow-metadata 1.17.2 requires protobuf>=4.25.2; python_version >= "3.11", but you have protobuf 4.24.4 which is incompatible.
tensorrt-llm 0.18.0 requires transformers<4.48.0,>=4.47.0, but you have transformers 4.51.3 which is incompatible.

@gabisponciano
gabisponciano marked this pull request as draft November 26, 2025 19:25
@github-actions github-actions Bot added enhancement Improvements to existing features dependencies Pull requests that update a dependency file python Pull requests that update python code labels Nov 26, 2025
@gabisponciano
gabisponciano marked this pull request as ready for review November 26, 2025 19:27
@gabisponciano gabisponciano self-assigned this Nov 26, 2025

@renanpdef renanpdef left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement Improvements to existing features python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants