feat(chat): add AskQuestions mode for contextual clarification - #776
Open
SeleiXi wants to merge 4 commits into
Open
feat(chat): add AskQuestions mode for contextual clarification#776SeleiXi wants to merge 4 commits into
SeleiXi wants to merge 4 commits into
Conversation
get_messages_for_context only loaded role/content, so extract_ask_user_clarifications always saw empty events and the model forgot prior card Q&A.
Resolved ask_user exchanges happened before the assistant produced the row's answer, so they must precede the row's content in both _build_history() and format_messages_as_transcript(). The previous order (assistant content first, clarification second) made later turns see the answer before the user supplied the missing context, confusing the model and polluting rolling summaries. Update the test that had locked in the wrong order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an explicit Ask Questions mode. When enabled, it requires the model to first inspect the current request and conversation context, identify the most important missing information, and ask the user a focused set of clarification questions before completing the task.
Motivation
Users do not always know how to formulate a complete request. In many cases, they may know the outcome they want, but may not know:
Key changes
ask_questionsmode across the runtime, CLI, and web capability picker.askCLI alias.ask_useron the first internal loop round while suppressing any pre-tool narration.ask_userquestions and answers in later-turn context.Use Case & Screenshot
Related Issues
Closes #775
Module(s) Affected
agentsapiconfigcoreknowledgeloggingservicestoolsutilsweb(Frontend)docs(Documentation)scriptstests...Checklist
pre-commit run --all-filesand fixed any issues.