Repository navigation
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
file:URL as an input whose timestamp cannot be verified.Why
UpToDateCheckercurrently ignoresURISyntaxExceptionwhen converting auxiliary input URLs to files. If the other timestamps make the output look current, ProGuard can then throwUpToDateExceptionand skip processing even though that input was never checked.Returning through the existing
IllegalStateExceptionpath is conservative: ProGuard runs normally whenever an input timestamp cannot be established.Verification
A minimal reproducer with an output timestamp of 1000 ms and a newer dictionary timestamp of 2000 ms reports the output as up to date before this change when the dictionary URL contains an unescaped space. With this change it follows the existing outdated-output path. The added
UpToDateCheckerTestcaptures that regression for CI.