Repository navigation
tech(Build): pin patched node versions across workflows - #1583
Merged
Merged
Conversation
ClemRz
approved these changes
Oct 22, 2026
ClemRz
left a comment
Contributor
There was a problem hiding this comment.
Suggestions (Should Consider)
.github/workflows/azure-static-web-apps-orange-rock-0d4f87503.ymlMerging intodevelopis a production release, and this changes the deploy from an Oryx build to a prebuilt upload (skip_app_build: true). The PR notes the Azure preview deployment is still unchecked. Consider confirming that the preview serves the app, thatstaticwebapp.config.json(navigationFallback, headers) is present indist/, and that refreshing a client-side route works before merging..github/workflows/azure-static-web-apps-orange-rock-0d4f87503.ymlThe install and build steps do not usecache: 'yarn'insetup-node, unlike the other workflows. This is correct but slower; consider adding it if deploy time matters..github/workflows/test.ymlcommand-prefix: '--no-install'relies on howcypress-io/github-actioncomposes thenpxcommand. The PR reports a headless Firefox smoke test, so this looks verified. Consider also checking the first CI E2E run in Chrome to confirm that Cypress resolves from the installed dependencies.package.json/packages/web-app/package.jsonTheengines.noderange^24.22.1 || >=26.12.1is now duplicated in two files and.nvmrc. The README documents this, which helps. Optionally, a small CI check could keep the three in sync.
Nitpicks (Optional)
.github/workflows/lint.yml,translations.ymlHardcodingname: build (24)andcheck-translations (24)keeps the required-check names stable. A short note in the repo docs that they must match branch protection might help future edits.README.mdThe badge now reads24.22.1_LTSand will need a manual update with each.nvmrcbump. Consider adding it to the update checklist in the new paragraph.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-rock-0d4f87503-1583.westeurope.azurestaticapps.net |
Contributor
Author
|
Addressed the review in 7da0847:
The PR description now reflects the final implementation and completed validation. No additional dependencies or CI jobs were introduced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What
Use Node 24.22.1 for development, builds and CI. The root
engines.nodedefines supported release lines;
.nvmrcpins the exact version used by CI.🤷♂️ Why
The October Node.js security release
fixes vulnerabilities affecting the repository's development and build runtimes.
Azure previously built with Node 24.13.0, and cached CI / Cypress action runtimes
could also select older Node versions. The deployed application is a static SPA.
🔍 How
.nvmrcin every Node workflow, including before release-versioncomputation with
npx. Keep the compatibility range in the root package only;the private web-app workspace no longer duplicates it.
names and document their relationship to
developbranch protection.configuration and dependency cache, then upload
dist/withskip_app_build: true. Preserve the app-version and Turnstile build variables.npx --no-installunder the selected Node runtime whileretaining the existing browser / spec matrix.
and Cypress/Electron runtimes. Link version references to
.nvmrcinstead ofduplicating the patch number in the README and badge.
🧪 Testing
configuration; built configuration matches the source.
actionlinton the modified workflows.yarn lint --ignore-pattern '**/*.local/**': no errors. The exclusionskips existing local generated E2E builds. The CI lint job also passes.
the follow-up commit's unit job also passes.
and used Node 24.22.1. A local Cypress configuration/task smoke test also
confirmed Node 24.22.1.
succeeds with Oryx build skipped and
staticwebapp.config.jsonrecognized.nosniff,index / service-worker cache headers, immutable JS assets and manifest.
/ui/entrances, rendered page heading and successful reload. API callsmocked to avoid requests to the production backend.
📸 Previews
Azure preview