Skip to content

chore(tpu): update package dependencies - #4410

Draft
angelcaamal wants to merge 3 commits into
mainfrom
chore-update-tpu-deps
Draft

chore(tpu): update package dependencies#4410
angelcaamal wants to merge 3 commits into
mainfrom
chore-update-tpu-deps

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes Internal: b/549316417

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: tpu Issues related to the Cloud TPU API. samples Issues that are directly related to samples. labels Aug 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @google-cloud/tpu and c8 dependencies in tpu/package.json. The review feedback correctly highlights that both upgraded packages require Node.js >= 18.0.0, which conflicts with the current engine requirement of >=16.0.0. To resolve this, the engines.node field in package.json should be updated to >=18.0.0.

Comment thread tpu/package.json
},
"dependencies": {
"@google-cloud/tpu": "^3.5.0",
"@google-cloud/tpu": "^4.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The upgrade of @google-cloud/tpu to ^4.0.0 requires Node.js >= 18.0.0. This is incompatible with the current "engines": { "node": ">=16.0.0" } specified on line 6. The engines.node field needs to be updated to >=18.0.0 to support this package version.

References
  1. When a dependency upgrade requires a higher Node.js version than currently specified in 'engines.node', consider upgrading the 'engines.node' requirement to a supported version (e.g., '>= 18' or '>= 20') instead of reverting the dependency version.

Comment thread tpu/package.json
},
"devDependencies": {
"c8": "^10.0.0",
"c8": "^12.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similarly, c8 version ^12.0.0 also requires Node.js >= 18.0.0. Consider upgrading the engines.node requirement to >=18.0.0 to support this and other upgraded dependencies.

References
  1. When a dependency upgrade requires a higher Node.js version than currently specified in 'engines.node', consider upgrading the 'engines.node' requirement to a supported version (e.g., '>= 18' or '>= 20') instead of reverting the dependency version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: tpu Issues related to the Cloud TPU API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant