chore(tpu): update package dependencies - #4410
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the @google-cloud/tpu and c8 dependencies in tpu/package.json. The review feedback correctly highlights that both upgraded packages require Node.js >= 18.0.0, which conflicts with the current engine requirement of >=16.0.0. To resolve this, the engines.node field in package.json should be updated to >=18.0.0.
| }, | ||
| "dependencies": { | ||
| "@google-cloud/tpu": "^3.5.0", | ||
| "@google-cloud/tpu": "^4.0.0", |
There was a problem hiding this comment.
The upgrade of @google-cloud/tpu to ^4.0.0 requires Node.js >= 18.0.0. This is incompatible with the current "engines": { "node": ">=16.0.0" } specified on line 6. The engines.node field needs to be updated to >=18.0.0 to support this package version.
References
- When a dependency upgrade requires a higher Node.js version than currently specified in 'engines.node', consider upgrading the 'engines.node' requirement to a supported version (e.g., '>= 18' or '>= 20') instead of reverting the dependency version.
| }, | ||
| "devDependencies": { | ||
| "c8": "^10.0.0", | ||
| "c8": "^12.0.0", |
There was a problem hiding this comment.
Similarly, c8 version ^12.0.0 also requires Node.js >= 18.0.0. Consider upgrading the engines.node requirement to >=18.0.0 to support this and other upgraded dependencies.
References
- When a dependency upgrade requires a higher Node.js version than currently specified in 'engines.node', consider upgrading the 'engines.node' requirement to a supported version (e.g., '>= 18' or '>= 20') instead of reverting the dependency version.
Description
Fixes Internal: b/549316417
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.