Repository navigation
Fix for shutters not closing - #21
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates HomeShift’s cover heat-protection feature so that, when the outdoor temperature exceeds the configured threshold during the active time window, the integration can close covers by default (instead of calling stop_cover), while also allowing users to configure which cover service is called.
Changes:
- Add a new configuration option (
cover_action) to choose betweenclose_cover(default) andstop_cover. - Update CoverManager to call the configured cover service when heat protection triggers.
- Extend tests and translations to cover the new default behavior and the configurable action.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
custom_components/homeshift/cover_manager.py |
Uses configurable cover_action when triggering heat protection. |
custom_components/homeshift/const.py |
Adds CONF_COVER_ACTION and DEFAULT_COVER_ACTION. |
custom_components/homeshift/config_flow.py |
Adds a dropdown selector for cover action in the covers step. |
tests/test_coordinator_features.py |
Updates/extends tests to assert default close_cover and optional stop_cover. |
custom_components/homeshift/translations/en.json |
Adds UI strings for the new cover action option and updates descriptions. |
custom_components/homeshift/translations/fr.json |
Adds UI strings for the new cover action option and updates descriptions. |
.devcontainer/devcontainer.json |
Adds forced DNS settings in the devcontainer configuration. |
Gamso
force-pushed
the
fix/close_cover_auto
branch
from
May 24, 2026 14:14
db03787 to
a6bda13
Compare
Gamso
force-pushed
the
fix/close_cover_auto
branch
from
May 24, 2026 14:50
50bbb9c to
0713df4
Compare
…rature exceeds the configured threshold during the active time window, the integration can close covers by default (instead of calling stop_cover), while also allowing users to configure which cover service is called.
Changes:
Add a new configuration option (cover_action) to choose between close_cover (default), stop_cover and favorite button.
Add entity is_heat_protection_active.
Update CoverManager to call the configured cover service when heat protection triggers.
Extend tests and translations to cover the new default behavior and the configurable action.
Gamso
force-pushed
the
fix/close_cover_auto
branch
from
May 25, 2026 12:47
0713df4 to
89cd2c1
Compare
- Add binary_sensor.py: 'Cover Heat Active' entity (BinarySensorDeviceClass.HEAT) shows whether heat protection conditions are currently met (in window + temp > threshold) - Add CONF_COVER_MY_BUTTON: optional button entity (e.g. Somfy My position) that takes priority over the cover action when set - Remove 'my_position' from the action dropdown — just fill in the button entity - Fix default action from stop_cover → close_cover - Add CONF_COVER_ACTION selector (close_cover / stop_cover) with accurate descriptions (stop_cover halts movement, My position is a separate button) - Expose coordinator.is_heat_protection_active() as public method - 168 tests passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
async_check_heat_protectiondocstring to match current behavior