Repository navigation
Feat/add icons - #19
Merged
Merged
Conversation
Previously, thermostat tag filtering was only applied when the thermostat mode was THERMOSTAT_OFF_KEY. In "Heating" mode, a scheduler tagged "Cooling" could still be enabled if it matched the active day_mode list. The logic is now generalized for any scheduler containing thermostat tags: - If the tag matches the current thermostat mode → allowed (follows day_mode rules) - If the tag does not match the current thermostat mode → force-disabled This naturally covers the "Off" mode as well: since no scheduler carries an "Off" tag, all thermostat-related schedulers are disabled without requiring special handling.
Fix return line format => LF. Bump to 1.4.5
Contributor
There was a problem hiding this comment.
Pull request overview
Adds branding assets for the HomeShift Home Assistant custom integration and bumps the integration version accordingly.
Changes:
- Add
custom_components/homeshift/brand/icon.pngbrand icon asset. - Bump integration version in
custom_components/homeshift/manifest.jsonto1.4.5. - Normalize/adjust formatting in a couple of repo utility files (
scripts/init_calendars.py,.bashrc).
Reviewed changes
Copilot reviewed 1 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/init_calendars.py | Formatting-only changes; script remains functionally the same. |
| custom_components/homeshift/manifest.json | Version bump to align with the release containing branding assets. |
| custom_components/homeshift/brand/icon.png | New brand icon asset for the integration. |
| .bashrc | Formatting-only change (no functional change). |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.