Skip to content

[BUGFIX] Fix timestamp logic for FPS-independent input timings - #7791

Open
iLauncherDev wants to merge 1 commit into
FunkinCrew:developfrom
iLauncherDev:fix_FNF_input
Open

[BUGFIX] Fix timestamp logic for FPS-independent input timings#7791
iLauncherDev wants to merge 1 commit into
FunkinCrew:developfrom
iLauncherDev:fix_FNF_input

Conversation

@iLauncherDev

@iLauncherDev iLauncherDev commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Linked Issues

Description

This patch make sure to not call PreciseInputManager.getCurrentTimestamp for every input potentially causing time drifts because of tracing (they can cost some ms in the update loop)

Screenshots/Videos

@github-actions github-actions Bot added status: pending triage Awaiting review. size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels Jul 25, 2026
@NotHyper-474 NotHyper-474 added type: minor bug Involves a minor bug or issue. topic: scoring Involves the game's ranking and scoring systems. labels Jul 25, 2026
@iLauncherDev iLauncherDev changed the title Use the oldFrameTimestamp to keep consistency timing between different FPS [BUGFIX] Use the oldFrameTimestamp to keep consistency input timing between different FPS Jul 25, 2026
@iLauncherDev
iLauncherDev marked this pull request as ready for review July 25, 2026 00:28
@Hundrec
Hundrec requested a review from Kade-github July 25, 2026 09:00
@Hundrec Hundrec changed the title [BUGFIX] Use the oldFrameTimestamp to keep consistency input timing between different FPS [BUGFIX] Use oldFrameTimestamp for FPS-independent input timings Jul 25, 2026
@github-actions github-actions Bot added size: medium A medium pull request with 100 or fewer changes. and removed size: small A small pull request with 10 or fewer changes. labels Jul 25, 2026
@iLauncherDev iLauncherDev changed the title [BUGFIX] Use oldFrameTimestamp for FPS-independent input timings [BUGFIX] Use lastFrameTimestamp for FPS-independent input timings Jul 25, 2026
@iLauncherDev iLauncherDev changed the title [BUGFIX] Use lastFrameTimestamp for FPS-independent input timings [BUGFIX] Fix timestamp logic for FPS-independent input timings Jul 25, 2026
@NotHyper-474 NotHyper-474 added status: rejected Issue did not pass review or PR cannot be approved. and removed type: minor bug Involves a minor bug or issue. topic: scoring Involves the game's ranking and scoring systems. status: pending triage Awaiting review. pr: haxe PR modifies game code. labels Jul 25, 2026
@NotHyper-474
NotHyper-474 removed the request for review from Kade-github July 25, 2026 23:16
@iLauncherDev iLauncherDev reopened this Jul 26, 2026
@github-actions github-actions Bot added the pr: haxe PR modifies game code. label Jul 26, 2026
@NotHyper-474 NotHyper-474 added type: minor bug Involves a minor bug or issue. topic: scoring Involves the game's ranking and scoring systems. status: pending triage Awaiting review. and removed status: rejected Issue did not pass review or PR cannot be approved. labels Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: scoring Involves the game's ranking and scoring systems. type: minor bug Involves a minor bug or issue.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iLauncherDev @NotHyper-474