[ENHANCEMENT] Add custom callback params to VideoCutscene - #7789
Open
notboboxslayer wants to merge 1 commit into
Open
[ENHANCEMENT] Add custom callback params to VideoCutscene#7789notboboxslayer wants to merge 1 commit into
notboboxslayer wants to merge 1 commit into
Conversation
github-actions
Bot
added
size: medium
notboboxslayer
changed the title
Hundrec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes todo in
VideoCutscene.hxby allowingVideoCutscene.play()to accept an optional completion callback function.Before, video cutscenes were hardcoded to trigger default actions based on
CutsceneType. With this change, if anonFinishcallback is given, it executes when the video ends or finishes transitioning. If no callback is provided, it falls back to the standard types (STARTING,ENDING,MIDSONG).By doing this, it makes cutscene calls a total of 0.5% easier!