[BUGFIX] Hide duplicate sprite when dragging event - #7788
Open
kiryvajiravuth wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
size: small
NotHyper-474
added
type: minor bug
kiryvajiravuth
changed the title
Hundrec
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Might closes #6227
Description
When dragging a note or event in the ChartEditor (e.g., after double-clicking it then drags it) the grid ghost sprites (
gridGhostEvent,gridGhostNote,gridGhostHoldNote) remain visible at their last position, creating a "clone" of the dragged item.This fix hides all three ghost sprites while any drag target is active (
dragTargetNoteordragTargetEventis not null) removes the clones. The ghosts are naturally re-shown byhandleCursor()once the drag ends.Note:
This bug is very inconsistent to replicate , sometimes you have to doubleclick the event then drags it while sometimes it requires you to doubleclick then click outside of the charting grid then drag which confuses me even more 😭
Screenshots/Videos
Before :
before.mp4
After :
after.mp4