[ENHANCEMENT] Update player strumline with Lime instead of Flixel - #7765
Open
ADA-Funni wants to merge 2 commits into
Open
[ENHANCEMENT] Update player strumline with Lime instead of Flixel#7765ADA-Funni wants to merge 2 commits into
ADA-Funni wants to merge 2 commits into
Conversation
…xel. This makes the player's strumline update before anything in the game, kind of like the reason why inputs are faster than Flixel's built-in inputs in this engine.
github-actions
Bot
added
status: pending triage
Hundrec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the player's strumline update before anything in the game, kind of like the reason why inputs are faster than Flixel's built-in inputs in this engine.
This PR also makes the player's notes ignore the locked FPS, but inputs do that anyway, and the player's notes are more like a second layer of input logic than anything else.
In this PR, the player's notes won't draw with the window (as
FlxBasicjust handles the drawing for us), but they'll update with it, meaning timing stuff updates with the window so you can hit tighter timings for example.Also this PR only applies to the PLAYER's notes, the opponent's notes just update with
FlxBasic's loopAlso I believe this will be very rejected, but I thought I should try anyway lol