[OPTIMIZATION] Change FunkinGroup.updateChildren to use the FlxPoint pool - #7446
Closed
MightyTheArmiddilo wants to merge 1 commit into
Closed
[OPTIMIZATION] Change FunkinGroup.updateChildren to use the FlxPoint pool#7446MightyTheArmiddilo wants to merge 1 commit into
FunkinGroup.updateChildren to use the FlxPoint pool#7446MightyTheArmiddilo wants to merge 1 commit into
Conversation
github-actions
Bot
added
size: tiny
Hundrec
added
status: pending triage
TechnikTil
reviewed
Jun 17, 2026
TechnikTil
left a comment
TechnikTil
left a comment
Contributor
There was a problem hiding this comment.
It would probably be better to reuse the same point throughout the entire instance instead of pulling from the pool every update.
You could also use FlxSprite._point, which is supposed to be used for rendering. Since we don't really render, why not use it for something else?
Contributor
Author
|
Superceded by/merged into #7753 |
NotHyper-474
added
status: rejected
Hundrec
added
status: duplicate
|
This pull request is a duplicate. Please direct all discussion to the original pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For some reason I had it make a new FlxPoint every time updateChildren ran so...