Repository navigation
Fix memory leak: remove pager listeners once the pager is persisted - #1999
Open
guillaume-sainthillier wants to merge 1 commit into
Open
guillaume-sainthillier wants to merge 1 commit into
guillaume-sainthillier wants to merge 1 commit into
Conversation
RegisterListenersService added listeners to the shared dispatcher for every pager and never removed them. A Messenger worker handling AsyncPersistPage messages provides a new pager with each message, so every page stayed referenced, with its objects, until the worker ran out of memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RegisterListenersServiceadds listeners to the shared dispatcher for every pager and never removes them. With--pager-persister=async, the Messenger worker provides a new pager perAsyncPersistPagemessage, so each listener keeps its pager (and the objects of its current page) alive.On a 2.15M-document index with
--max-per-page=5000, the worker grew by ~80 MB per page and hit a 2 GBmemory_limitafter 22 pages.The listeners are now removed on the pager's
PostPersistEvent.