Fix PIC32 MAC initialization call - #1350
Merged
rawalexe merged 1 commit intoJul 8, 2026
Merged
Conversation
Old-Ding
marked this pull request as ready for review
July 1, 2026 05:55
Contributor
Author
|
Follow-up verification:
I do not have the PIC32MZ/MPLAB XC32 target environment locally, so this remains a source-level build-fix patch rather than a target-tested driver validation. |
Pass the NetworkInterface_t pointer through to StartInitMac. The helper already requires the interface and uses it to iterate endpoints, so the PIC32 network interface currently fails to compile.
rawalexe
force-pushed
the
codex/fix-pic32-init-mac-argument
branch
from
July 8, 2026 20:03
71c748b to
8a446ea
Compare
AniruddhaKanhere
approved these changes
Jul 8, 2026
AniruddhaKanhere
left a comment
AniruddhaKanhere
left a comment
Member
There was a problem hiding this comment.
Thank you for that change @Old-Ding.
As you mentioned, this only fixes the build but the pic32 is still NOT tested with the multi-interface stuff.
That being said, the change is good. Approved.
rawalexe
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1252.
Pass the current
NetworkInterface_t *intoStartInitMac()from thePIC32MZ network interface initialisation path. The helper is declared and
defined with that parameter, and it uses the interface when iterating the
configured endpoints.
Test Steps
git diff --check upstream/main...HEADStartInitMachas one call site and it now passespxInterface.Unit tests were not run locally because this Windows environment does not
have the repo test dependencies installed (
cmake,ninja,ruby,make),and this PIC32 target file depends on the target/vendor build environment.
Checklist:
Related Issue
#1252
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.