Fix scrollbars appearing in inbox-zero animation iframes - #2821
Open
m-salman-afzal wants to merge 2 commits into
Open
Fix scrollbars appearing in inbox-zero animation iframes#2821m-salman-afzal wants to merge 2 commits into
m-salman-afzal wants to merge 2 commits into
Conversation
The five Tumult Hype exports render a stage that is exactly 600x500, matching the iframe dimensions set in empty-list-state.less. Chromium 43 (electron 41.7.2 -> 43.4.1) renders non-overlay scrollbars that reserve layout space rather than floating above content, so the stage no longer fit its viewport: one scrollbar appeared, consumed ~15px, pushed the other axis into overflow, and the second appeared in turn. The scrollbars belong to the iframe's own viewport, which the embedding document cannot style — overflow on an <iframe> element applies to the replaced box, not the document inside it. Set overflow:hidden on the root element of each export instead, where it propagates to the viewport and suppresses both axes. Preferred over scrolling="no" on the iframe, which achieves the same result via the frame owner but is non-conforming and long deprecated.
|
This pull request has been mentioned on Mailspring Community. There might be relevant details there: https://community.getmailspring.com/t/scrollbar-on-empty-animations/14555/1 |
Collaborator
|
Thanks for committing this! I think this makes sense, but one of the five is |
Author
|
No, I was testing something and may have forgotten about it. Will update. Thanks. I have updated the pr. Kindly recheck. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five Tumult Hype exports render a stage that is exactly 600x500, matching the iframe dimensions set in empty-list-state.less. Chromium 43 (electron 41.7.2 -> 43.4.1) renders non-overlay scrollbars that reserve layout space rather than floating above content, so the stage no longer fit its viewport: one scrollbar appeared, consumed ~15px, pushed the other axis into overflow, and the second appeared in turn.
The scrollbars belong to the iframe's own viewport, which the embedding document cannot style — overflow on an <iframe> element applies to the replaced box, not the document inside it. Set overflow:hidden on the root element of each export instead, where it propagates to the viewport and suppresses both axes.
Preferred over scrolling="no" on the iframe, which achieves the same result via the frame owner but is non-conforming and long deprecated.