Skip to content

fix(action): mask every line of multi-line secrets and randomize the env delimiter #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BryanFRD merged 2 commits into from
Oct 28, 2026
Merged

fix(action): mask every line of multi-line secrets and randomize the env delimiter #336

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4054f54
fix(action): mask every line of multi-line secrets and randomize the …
BryanFRD Oct 28, 2026
7ab4ee8
fix(action): generate the env delimiter from /dev/urandom instead of …
BryanFRD Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions action/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,15 +130,23 @@ runs:
fi

keys=$(jq -r 'keys[]' "$out")
valfile="$(mktemp)"
trap 'shred -u "$out" "$valfile" 2>/dev/null || rm -f "$out" "$valfile"' EXIT
for k in $keys; do
v="$(jq -r --arg k "$k" '.[$k]' "$out")"
echo "::add-mask::$v"
jq -j --arg k "$k" '.[$k]' "$out" > "$valfile"
while IFS= read -r line || [[ -n "$line" ]]; do
[[ -n "$line" ]] && echo "::add-mask::$line"
done < "$valfile"
if [[ "$EXPORT_ENV" == "true" ]]; then
varname="${OUTPUT_PREFIX}${k}"
delim="ghadelim_$(openssl rand -hex 16)"
Comment thread
ferrfleet-interne[bot] marked this conversation as resolved.
Resolved
if grep -qF -- "$delim" "$valfile"; then
echo "::error::secret value contains the env delimiter, aborting" >&2
exit 1
fi
{
printf '%s<<FERRVAULT_EOF\n' "$varname"
printf '%s\n' "$v"
printf 'FERRVAULT_EOF\n'
printf '%s<<%s\n' "${OUTPUT_PREFIX}${k}" "$delim"
cat "$valfile"
printf '\n%s\n' "$delim"
} >> "$GITHUB_ENV"
fi
done
Expand Down
Loading